Update go runtime versions #458
Conversation
|
@shivakunv I don't understand the reason for this change. Can you please provide the context in the PR description |
updated the description |
shivakunv
force-pushed
the
updatecudagoversion
branch
from
60dc0ac to
44e848a
Compare
We no longer use the ${CUDA_VERSION} build arg. The CUDA base image that we use is referenced explicitly without any variables in the Dockerfile. We have done this to enable dependabot bumps of the cuda base image version |
shivakunv
changed the title
Signed-off-by: Shiva Kumar (SW-CLOUD) <shivaku@nvidia.com>
shivakunv
force-pushed
the
updatecudagoversion
branch
from
44e848a to
3b9de99
Compare
removed CUDA_VERSION and updated the description. |
|
@tariq1890 PTAL |
|
LGTM. I am okay to merge this if @cdesiniotis also approves |
|
I am okay with this change, but users should not have to set the |
removed from the cloud-native-docs: |
3 participants
Issue: https://github.com/NVIDIA/gpu-driver-container/issues/169
we are providing an option for users to specify
GOLANG_VERSION.When using
:=(init variable , will discard supplied variable before make), it does not take variables passed before the make command (e.g.,GOLANG_VERSION make).Instead, users need to specify it like this:
make GOLANG_VERSION=..., e.g.VGPU_GUEST_DRIVER_VERSION=${VGPU_DRIVER_VERSION} IMAGE_NAME=${PRIVATE_REGISTRY}/driver make push-vgpuguest-${OS_TAG} GOLANG_VERSION=${GOLANG_VERSION}which differs from the command
VGPU_GUEST_DRIVER_VERSION=${VGPU_DRIVER_VERSION} IMAGE_NAME=${PRIVATE_REGISTRY}/driver GOLANG_VERSION=${GOLANG_VERSION} make push-vgpuguest-${OS_TAG}Now, with
?=both command styles will work.Final command will be:-
VGPU_GUEST_DRIVER_VERSION=${VGPU_DRIVER_VERSION} IMAGE_NAME=${PRIVATE_REGISTRY}/driver GOLANG_VERSION=${GOLANG_VERSION} make push-vgpuguest-${OS_TAG}